Skip to content

🐛Storage-Worker: ensure startup waits for fastapi application readyness #7442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

🐛Storage-Worker: ensure startup waits for fastapi application readyness #7442

merged 1 commit into from
Mar 27, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 27, 2025 •
edited
Loading

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 27, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 27, 2025
@sanderegg sanderegg self-assigned this Mar 27, 2025
@sanderegg sanderegg requested a review from bisgaard-itis March 27, 2025 10:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.26%. Comparing base (af8e683) to head (72369e7).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (af8e683) and HEAD (72369e7). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (af8e683) HEAD (72369e7)
unittests 30 15
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7442       +/-   ##
===========================================
- Coverage   87.43%   77.26%   -10.18%     
===========================================
  Files        1717     1098      -619     
  Lines       66608    46510    -20098     
  Branches     1132      215      -917     
===========================================
- Hits        58241    35935    -22306     
- Misses       8046    10507     +2461     
+ Partials      321       68      -253
Flag Coverage Δ *Carryforward flag
integrationtests 65.15% <ø> (ø) Carriedforward from af8e683
unittests 87.62% <70.00%> (+1.00%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.90% <70.00%> (-0.34%) ⬇️
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.10%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.08% <ø> (-26.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8e683...72369e7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 0d58ad8 into ITISFoundation:master Mar 27, 2025
70 of 79 checks passed
@sanderegg sanderegg deleted the storage-worker/enhance-shakyness branch March 27, 2025 10:35
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@pcrespov pcrespov Awaiting requested review from pcrespov

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:storage issue related to storage service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

2 participants

@sanderegg @giancarloromeo